You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by co...@apache.org on 2017/01/24 12:08:37 UTC

opennlp git commit: OPENNLP-955: Fixes docbegin feature generator

Repository: opennlp
Updated Branches:
  refs/heads/master 91d0ce5a2 -> 5166f3dd0


OPENNLP-955: Fixes docbegin feature generator

The docbegin was mapped to PreviousMapFeatureGenerator instead of DocumentBeginFeatureGenerator. Also changed the name of the factory by appending the sufix.

Fixes OPENNLP-955
Closes apache/opennlp#84


Project: http://git-wip-us.apache.org/repos/asf/opennlp/repo
Commit: http://git-wip-us.apache.org/repos/asf/opennlp/commit/5166f3dd
Tree: http://git-wip-us.apache.org/repos/asf/opennlp/tree/5166f3dd
Diff: http://git-wip-us.apache.org/repos/asf/opennlp/diff/5166f3dd

Branch: refs/heads/master
Commit: 5166f3dd04980177e46293408d998087040d4c19
Parents: 91d0ce5
Author: William D C M SILVA <co...@apache.org>
Authored: Tue Jan 24 10:06:49 2017 -0200
Committer: William D C M SILVA <co...@apache.org>
Committed: Tue Jan 24 10:08:14 2017 -0200

----------------------------------------------------------------------
 .../java/opennlp/tools/util/featuregen/GeneratorFactory.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/opennlp/blob/5166f3dd/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/GeneratorFactory.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/GeneratorFactory.java b/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/GeneratorFactory.java
index bccbea2..fa97f43 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/GeneratorFactory.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/GeneratorFactory.java
@@ -259,15 +259,15 @@ public class GeneratorFactory {
     }
   }
 
-  static class DocumentBeginFeatureGenerator implements XmlFeatureGeneratorFactory {
+  static class DocumentBeginFeatureGeneratorFactory implements XmlFeatureGeneratorFactory {
 
     public AdaptiveFeatureGenerator create(Element generatorElement,
         FeatureGeneratorResourceProvider resourceManager) {
-      return new PreviousMapFeatureGenerator();
+      return new DocumentBeginFeatureGenerator();
     }
 
     static void register(Map<String, XmlFeatureGeneratorFactory> factoryMap) {
-      factoryMap.put("docbegin", new DocumentBeginFeatureGenerator());
+      factoryMap.put("docbegin", new DocumentBeginFeatureGeneratorFactory());
     }
   }
 
@@ -633,7 +633,7 @@ public class GeneratorFactory {
     CharacterNgramFeatureGeneratorFactory.register(factories);
     DefinitionFeatureGeneratorFactory.register(factories);
     DictionaryFeatureGeneratorFactory.register(factories);
-    DocumentBeginFeatureGenerator.register(factories);
+    DocumentBeginFeatureGeneratorFactory.register(factories);
     PreviousMapFeatureGeneratorFactory.register(factories);
     SentenceFeatureGeneratorFactory.register(factories);
     TokenClassFeatureGeneratorFactory.register(factories);