You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/07 09:18:16 UTC
[GitHub] [calcite] Aaaaaaron opened a new pull request #2057: minor, add log when abort optimization due to VolcanoTimeoutException.
Aaaaaaron opened a new pull request #2057:
URL: https://github.com/apache/calcite/pull/2057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 closed pull request #2057: Following [CALCITE-3753] add log when aborting optimization due to VolcanoTimeoutException (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #2057:
URL: https://github.com/apache/calcite/pull/2057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2057: Following [CALCITE-3753] add log when abort optimization due to VolcanoTimeoutException
Posted by GitBox <gi...@apache.org>.
Aaaaaaron edited a comment on pull request #2057:
URL: https://github.com/apache/calcite/pull/2057#issuecomment-654718807
Current volcano planner may abort an optimization actively, it's critical path, worth a log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2057: Following [CALCITE-3753] add log when aborting optimization due to VolcanoTimeoutException
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on a change in pull request #2057:
URL: https://github.com/apache/calcite/pull/2057#discussion_r452307051
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -519,6 +519,7 @@ public RelNode findBestExp() {
try {
match.onMatch();
} catch (VolcanoTimeoutException e) {
+ LOGGER.warn("Catch VolcanoTimeoutException, abort optimization.");
root = canonize(root);
Review comment:
> How about "Volcano planning times out, cancels the subsequent optimization."
Revised
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2057: Following [CALCITE-3753] add log when aborting optimization due to VolcanoTimeoutException
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2057:
URL: https://github.com/apache/calcite/pull/2057#discussion_r452161828
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -519,6 +519,7 @@ public RelNode findBestExp() {
try {
match.onMatch();
} catch (VolcanoTimeoutException e) {
+ LOGGER.warn("Catch VolcanoTimeoutException, abort optimization.");
root = canonize(root);
Review comment:
How about "Volcano planning times out, cancels the subsequent optimization."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron commented on pull request #2057: minor, add log when abort optimization due to VolcanoTimeoutException.
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on pull request #2057:
URL: https://github.com/apache/calcite/pull/2057#issuecomment-654718807
Current volcano planner may abort an optimization actively, it's critical path, worth a log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2057: Following [CALCITE-3753] add log when aborting optimization due to VolcanoTimeoutException (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2057:
URL: https://github.com/apache/calcite/pull/2057#issuecomment-657167336
Need to capitalize the first letter in commit log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2057: Following [CALCITE-3753] add log when abort optimization due to VolcanoTimeoutException
Posted by GitBox <gi...@apache.org>.
Aaaaaaron edited a comment on pull request #2057:
URL: https://github.com/apache/calcite/pull/2057#issuecomment-654718807
Current volcano planner may abort an optimization actively, it's a critical path, worth a log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org