You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/29 07:34:40 UTC
[GitHub] [spark] MaxGekk opened a new pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
MaxGekk opened a new pull request #34140:
URL: https://github.com/apache/spark/pull/34140
### What changes were proposed in this pull request?
In the PR, I propose to take into account the SQL config `spark.sql.parquet.filterPushdown` while building the array of pushed down filters in v2 `ParquetScanBuilder`.
### Why are the changes needed?
Before the changes, `explain()` outputs some filters even filter pushdown to parquet is disabled:
```
== Physical Plan ==
*(1) Filter (isnotnull(c0#7) AND (c0#7 = 1))
+- *(1) ColumnarToRow
+- BatchScan[c0#7] ParquetScan DataFilters: [isnotnull(c0#7), (c0#7 = 1)], ... PushedFilters: [IsNotNull(c0), EqualTo(c0,1)] RuntimeFilters: []
```
### Does this PR introduce _any_ user-facing change?
If users parse `explain()`'s output, this PR can influence to them. But in general, it shouldn't. Also, need to highlight that the PR affects DSv2 only.
### How was this patch tested?
By running new test in `ParquetV2FilterSuite`:
```
$ build/sbt "test:testOnly *ParquetV2FilterSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-930124065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143712/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-930124065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143712/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34140:
URL: https://github.com/apache/spark/pull/34140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929999063
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48225/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929918685
**[Test build #143712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143712/testReport)** for PR 34140 at commit [`40a4771`](https://github.com/apache/spark/commit/40a477121b38d86e8a523a6f4b6cee94792dc643).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929999063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-930062837
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-930062837
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929918685
**[Test build #143712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143712/testReport)** for PR 34140 at commit [`40a4771`](https://github.com/apache/spark/commit/40a477121b38d86e8a523a6f4b6cee94792dc643).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929994100
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48225/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-930122768
**[Test build #143712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143712/testReport)** for PR 34140 at commit [`40a4771`](https://github.com/apache/spark/commit/40a477121b38d86e8a523a6f4b6cee94792dc643).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929999063
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48225/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929955274
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48225/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929918685
**[Test build #143712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143712/testReport)** for PR 34140 at commit [`40a4771`](https://github.com/apache/spark/commit/40a477121b38d86e8a523a6f4b6cee94792dc643).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34140:
URL: https://github.com/apache/spark/pull/34140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929918685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34140: [SPARK-36889][SQL] Respect `spark.sql.parquet.filterPushdown` by v2 parquet scan builder
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34140:
URL: https://github.com/apache/spark/pull/34140#issuecomment-929999063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org