You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Aditi Bhatnagar <ad...@gmail.com> on 2014/10/22 16:44:09 UTC
Review Request 27040: Replace hard-coded reap interval with a constant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/
-----------------------------------------------------------
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1935
https://issues.apache.org/jira/browse/MESOS-1935
Repository: mesos-git
Description
-------
Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
Diffs
-----
3rdparty/libprocess/include/process/reap.hpp 5e5051a
3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
3rdparty/libprocess/src/reap.cpp afd956b
3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
Diff: https://reviews.apache.org/r/27040/diff/
Testing
-------
Thanks,
Aditi Bhatnagar
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Oct. 22, 2014, 8:12 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [27040]
> >
> > Failed command: ./support/apply-review.sh -n -r 27040
> >
> > Error:
> > --2014-10-22 15:12:21-- https://reviews.apache.org/r/27040/diff/raw/
> > Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
> > Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
> > HTTP request sent, awaiting response... 200 OK
> > Length: 7434 (7.3K) [text/x-patch]
> > Saving to: '27040.patch'
> >
> > 0K ....... 100% 108M=0s
> >
> > 2014-10-22 15:12:21 (108 MB/s) - '27040.patch' saved [7434/7434]
> >
> > Successfully applied: Replace hard-coded reap interval with a constant
> >
> > Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
> >
> >
> > Review: https://reviews.apache.org/r/27040
> > Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> > 3rdparty/libprocess/include/process/reap.hpp:14: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
> > 3rdparty/libprocess/include/process/reap.hpp:15: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
> > Total errors found: 2
> > Failed to commit patch
fix these please and then i'll take a look.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review57798
-----------------------------------------------------------
On Oct. 22, 2014, 7:45 a.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 7:45 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1935
> https://issues.apache.org/jira/browse/MESOS-1935
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/reap.hpp 5e5051a
> 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
> 3rdparty/libprocess/src/reap.cpp afd956b
> 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review57798
-----------------------------------------------------------
Bad patch!
Reviews applied: [27040]
Failed command: ./support/apply-review.sh -n -r 27040
Error:
--2014-10-22 15:12:21-- https://reviews.apache.org/r/27040/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 7434 (7.3K) [text/x-patch]
Saving to: '27040.patch'
0K ....... 100% 108M=0s
2014-10-22 15:12:21 (108 MB/s) - '27040.patch' saved [7434/7434]
Successfully applied: Replace hard-coded reap interval with a constant
Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
Review: https://reviews.apache.org/r/27040
Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/include/process/reap.hpp:14: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
3rdparty/libprocess/include/process/reap.hpp:15: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
Total errors found: 2
Failed to commit patch
- Mesos ReviewBot
On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 2:45 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1935
> https://issues.apache.org/jira/browse/MESOS-1935
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/reap.hpp 5e5051a
> 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
> 3rdparty/libprocess/src/reap.cpp afd956b
> 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review60868
-----------------------------------------------------------
3rdparty/libprocess/include/process/reap.hpp~
<https://reviews.apache.org/r/27040/#comment102278>
remove this file (and please install the .gitignore template)
- Dominic Hamon
On Oct. 22, 2014, 7:45 a.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 7:45 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1935
> https://issues.apache.org/jira/browse/MESOS-1935
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/reap.hpp 5e5051a
> 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
> 3rdparty/libprocess/src/reap.cpp afd956b
> 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Aditi Bhatnagar <ad...@gmail.com>.
> On Oct. 22, 2014, 5:26 p.m., Ben Mahler wrote:
> > There is already a constant, MESOS-1935 is to ensure that code that previously hardcoded Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp.
Sorry, but I didn't find the constants in https://github.com/apache/mesos/blob/4693728e4f604a1cff6f01d5f2d8f0ec60eb2f96/3rdparty/libprocess/include/process/reap.hpp .
- Aditi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review57826
-----------------------------------------------------------
On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 2:45 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1935
> https://issues.apache.org/jira/browse/MESOS-1935
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/reap.hpp 5e5051a
> 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
> 3rdparty/libprocess/src/reap.cpp afd956b
> 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Alexander Rukletsov <al...@mesosphere.io>.
> On Oct. 22, 2014, 5:26 p.m., Ben Mahler wrote:
> > There is already a constant, MESOS-1935 is to ensure that code that previously hardcoded Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp.
>
> Aditi Bhatnagar wrote:
> Sorry, but I didn't find the constants in https://github.com/apache/mesos/blob/4693728e4f604a1cff6f01d5f2d8f0ec60eb2f96/3rdparty/libprocess/include/process/reap.hpp .
`MAX_REAP_INTERVAL()` acts as a constant.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review57826
-----------------------------------------------------------
On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 2:45 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1935
> https://issues.apache.org/jira/browse/MESOS-1935
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/reap.hpp 5e5051a
> 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
> 3rdparty/libprocess/src/reap.cpp afd956b
> 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review57826
-----------------------------------------------------------
There is already a constant, MESOS-1935 is to ensure that code that previously hardcoded Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp.
- Ben Mahler
On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 2:45 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1935
> https://issues.apache.org/jira/browse/MESOS-1935
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/reap.hpp 5e5051a
> 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
> 3rdparty/libprocess/src/reap.cpp afd956b
> 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>
Re: Review Request 27040: Replace hard-coded reap interval with a
constant
Posted by Aditi Bhatnagar <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 2:45 p.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1935
https://issues.apache.org/jira/browse/MESOS-1935
Repository: mesos-git
Description
-------
Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp
Diffs
-----
3rdparty/libprocess/include/process/reap.hpp 5e5051a
3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION
3rdparty/libprocess/src/reap.cpp afd956b
3rdparty/libprocess/src/reap.cpp~ PRE-CREATION
Diff: https://reviews.apache.org/r/27040/diff/
Testing
-------
Thanks,
Aditi Bhatnagar