You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "SkyeYoung (via GitHub)" <gi...@apache.org> on 2025/06/13 06:50:12 UTC
[PR] fix(stream_routes): logic for processing data [apisix-dashboard]
SkyeYoung opened a new pull request, #3117:
URL: https://github.com/apache/apisix-dashboard/pull/3117
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Fixed data processing logic for stream_routes-related components to ensure that data can be correctly echoed or submitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(JSONInput): toObject logic [apisix-dashboard]
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung merged PR #3117:
URL: https://github.com/apache/apisix-dashboard/pull/3117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(stream_routes): logic for processing data [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3117:
URL: https://github.com/apache/apisix-dashboard/pull/3117#discussion_r2144332389
##########
src/components/form/JsonInput.tsx:
##########
@@ -15,6 +15,7 @@
* limitations under the License.
*/
import { JsonInput, type JsonInputProps } from '@mantine/core';
+import { omit } from 'rambdax';
Review Comment:
[nitpick] Consider destructuring `objValue` directly from `props` (e.g., `const { objValue, ...restProps } = props`) instead of using `omit` to remove it, reducing an extra dependency and simplifying the code.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org