You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jimmy Xiang <jx...@cloudera.com> on 2015/03/03 01:38:39 UTC

Review Request 31648: HIVE-9830 Map join could dump a small table multiple times [Spark Branch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31648/
-----------------------------------------------------------

Review request for hive and Xuefu Zhang.


Bugs: HIVE-9830
    https://issues.apache.org/jira/browse/HIVE-9830


Repository: hive-git


Description
-------

1. Don't flush the file if the task is aborted.
2. Try to clean up partitial file if something goes wrong in flushing a file.

Ideally, we should no use a random file. We should use a fixed file name for this task this split.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java 9557efd 

Diff: https://reviews.apache.org/r/31648/diff/


Testing
-------


Thanks,

Jimmy Xiang


Re: Review Request 31648: HIVE-9830 Map join could dump a small table multiple times [Spark Branch]

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31648/#review75067
-----------------------------------------------------------

Ship it!


Ship It!

- Xuefu Zhang


On March 3, 2015, 12:38 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31648/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 12:38 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-9830
>     https://issues.apache.org/jira/browse/HIVE-9830
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> 1. Don't flush the file if the task is aborted.
> 2. Try to clean up partitial file if something goes wrong in flushing a file.
> 
> Ideally, we should no use a random file. We should use a fixed file name for this task this split.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java 9557efd 
> 
> Diff: https://reviews.apache.org/r/31648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>