[GitHub] [cordova-plugin-camera] hazems commented on a change in pull request #426: (android) allowEdit not working when sourceType is PHOTOLIBRARY

[GitBox <gi...@apache.org>]

hazems commented on a change in pull request #426: (android) allowEdit not working when sourceType is PHOTOLIBRARY
URL: https://github.com/apache/cordova-plugin-camera/pull/426#discussion_r282686127
 
 

 ##########
 File path: src/android/CameraLauncher.java
 ##########
 @@ -101,8 +101,10 @@ Licensed to the Apache Software Foundation (ASF) under one
 
     private static final String LOG_TAG = "CameraLauncher";
 
-    //Where did this come from?
-    private static final int CROP_CAMERA = 100;
+    //Crop Codes
+    private static final int CROP_OPERATION = 100;
+    private static final int CROP_CAMERA = CROP_OPERATION;
+    private static final int CROP_PHOTO_ALBUM = CROP_OPERATION + 900;
 
 Review comment:
   The reason is to give a clear distinction between CROP_CAMERA operation code and CROP_PHOTO_ALBUM operation code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org