You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/31 12:47:58 UTC
[GitHub] [flink] godfreyhe opened a new pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
godfreyhe opened a new pull request #13039:
URL: https://github.com/apache/flink/pull/13039
## What is the purpose of the change
*sql client has a lot of logic to execute an insert job, which can be simplified through `executeSql` method. This pr aims to do the improvement*
## Brief change log
- *remove `executeUpdate` method from Executor*
- *execute insert statement through `executeSql` method in CliClient*
- *remove the unused code*
## Verifying this change
This change is already covered by existing tests, such as LocalExecutorITCase.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-734724994
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e6b085f2eeb0dd04bd889abef4a7421e608a103 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088)
* 9ef9b719d6d15a3c16b5d6040d43870605c5cb31 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #13039:
URL: https://github.com/apache/flink/pull/13039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
}, {
"hash" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5095",
"triggerID" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ef9b719d6d15a3c16b5d6040d43870605c5cb31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089)
* c01abc39c30c262330d90da9e40071fc4afefee8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5095)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
}, {
"hash" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5095",
"triggerID" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c01abc39c30c262330d90da9e40071fc4afefee8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5095)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e6b085f2eeb0dd04bd889abef4a7421e608a103 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088)
* 9ef9b719d6d15a3c16b5d6040d43870605c5cb31 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667103437
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9e6b085f2eeb0dd04bd889abef4a7421e608a103 (Fri Jul 31 12:50:22 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18789).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-787786897
continue reviewing in #14962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e6b085f2eeb0dd04bd889abef4a7421e608a103 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088)
* 9ef9b719d6d15a3c16b5d6040d43870605c5cb31 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ef9b719d6d15a3c16b5d6040d43870605c5cb31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9e6b085f2eeb0dd04bd889abef4a7421e608a103 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
}, {
"hash" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5095",
"triggerID" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"triggerType" : "PUSH"
}, {
"hash" : "794bc890622440f135cbb580324e43a863b812c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10237",
"triggerID" : "794bc890622440f135cbb580324e43a863b812c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 794bc890622440f135cbb580324e43a863b812c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10237)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13039: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13039:
URL: https://github.com/apache/flink/pull/13039#issuecomment-667108728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5088",
"triggerID" : "9e6b085f2eeb0dd04bd889abef4a7421e608a103",
"triggerType" : "PUSH"
}, {
"hash" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089",
"triggerID" : "9ef9b719d6d15a3c16b5d6040d43870605c5cb31",
"triggerType" : "PUSH"
}, {
"hash" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c01abc39c30c262330d90da9e40071fc4afefee8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ef9b719d6d15a3c16b5d6040d43870605c5cb31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5089)
* c01abc39c30c262330d90da9e40071fc4afefee8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org