[GitHub] [james-project] jeantil commented on a diff in pull request #1440: [Boyscout] Some tiny improvements

["jeantil (via GitHub)" <gi...@apache.org>]

jeantil commented on code in PR #1440:
URL: https://github.com/apache/james-project/pull/1440#discussion_r1104289414


##########
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java:
##########
@@ -382,7 +382,7 @@ protected Response doAuthTest(SMTPSession session, Username username, String pas
 
                 if (res != null) {
                     if (SMTPRetCode.AUTH_FAILED.equals(res.getRetCode())) {
-                        LOGGER.info("AUTH method {} failed", authType);
+                        LOGGER.warn("AUTH method {} failed", authType);
                     } else if (SMTPRetCode.AUTH_OK.equals(res.getRetCode())) {

Review Comment:
   I'm curious, why do you think this is worth raising to `warn`? 
   At my current company, warns and errors result in sentry notifications to the corresponding engineering team, we tend to avoid notifications for client errors. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org