[GitHub] [superset] kgabryje commented on a change in pull request #17046: fix: dropdown placement for cascading filters popover

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #17046:
URL: https://github.com/apache/superset/pull/17046#discussion_r730719671



##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -278,6 +279,11 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
           // @ts-ignore
           value={filterState.value || []}
           disabled={isDisabled}
+          getPopupContainer={
+            showOverflow
+              ? () => document.getElementsByClassName('cascade-popover')

Review comment:
       Doesn't it return an array? Maybe we should use `getElementById`? Or react ref?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org