You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 15:42:36 UTC
[GitHub] [arrow-datafusion] mvanschellebeeck opened a new pull request, #4246: Fix clippy failres
mvanschellebeeck opened a new pull request, #4246:
URL: https://github.com/apache/arrow-datafusion/pull/4246
Closes #4245
Running `./dev/rust_lint.sh` no longer fails
`#[allow(clippy::manual_filter)]` was added because it [wrongly suggests a filter when the match has side-effects](https://github.com/rust-lang/rust-clippy/issues/9766).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4246: Fix nightly clippy failures
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4246:
URL: https://github.com/apache/arrow-datafusion/pull/4246#issuecomment-1318499854
Benchmark runs are scheduled for baseline = 7a81e9fb5382612c75bee0b4c46494a20e9fd7da and contender = 929a17525917727aa99b26667e9c3a8c55bd67c3. 929a17525917727aa99b26667e9c3a8c55bd67c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d014563368df490dbb78d0b747d83452...98c330be311a45268065121b468f651a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/74097c0157c547f6a7af46f643507837...970041cb7da44dfab32104f069cf94a0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd5cba743b15426e9f4b79df80331280...4f80ed30c0af438f892dab5460de47a0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bd7708b9887b41ca87e24e7400600448...476a7d50b27644949b7c0b0bf39b8357/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mvanschellebeeck closed pull request #4246: Fix clippy failures
Posted by GitBox <gi...@apache.org>.
mvanschellebeeck closed pull request #4246: Fix clippy failures
URL: https://github.com/apache/arrow-datafusion/pull/4246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4246: Fix nightly clippy failures
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4246:
URL: https://github.com/apache/arrow-datafusion/pull/4246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mvanschellebeeck commented on pull request #4246: Fix clippy failures
Posted by GitBox <gi...@apache.org>.
mvanschellebeeck commented on PR #4246:
URL: https://github.com/apache/arrow-datafusion/pull/4246#issuecomment-1317273219
Turns out I was on nightly - closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org