You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/28 08:34:47 UTC

[GitHub] [inlong] leezng opened a new pull request, #6653: [INLONG-6651][Dashboard] Add settings for agent's data report-to

leezng opened a new pull request, #6653:
URL: https://github.com/apache/inlong/pull/6653

   - Fixes #6651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #6653: [INLONG-6651][Dashboard] Add settings for data report type

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6653:
URL: https://github.com/apache/inlong/pull/6653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #6653: [INLONG-6651][Dashboard] Add settings for data report type

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6653:
URL: https://github.com/apache/inlong/pull/6653#discussion_r1033433648


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -247,6 +247,10 @@
   "meta.Group.InlongGroupOwners": "责任人",
   "meta.Group.InlongGroupOwnersExtra": "责任人，可查看、修改数据流组信息",
   "meta.Group.InlongGroupIntroduction": "描述",
+  "meta.Group.DataReportType": "数据上报",
+  "meta.Group.DataReportType.DataProxyWithSource": "发往DataProxy并通过Source响应",

Review Comment:
   理解起来有歧义。建议修改为：
   ```
   发往DataProxy，待DataProxy接收到数据后再响应
   发往DataProxy，待DataProxy发送出数据后再响应
   发往MQ，待MQ接收到数据后再响应
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #6653: [INLONG-6651][Dashboard] Add settings for data report type

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6653:
URL: https://github.com/apache/inlong/pull/6653#discussion_r1033434648


##########
inlong-dashboard/src/locales/en.json:
##########
@@ -247,6 +247,10 @@
   "meta.Group.InlongGroupOwners": "Inlong Group Owners",
   "meta.Group.InlongGroupOwnersExtra": "Can view, modify group info",
   "meta.Group.InlongGroupIntroduction": "Description",
+  "meta.Group.DataReportType": "ReportDataTo",
+  "meta.Group.DataReportType.DataProxyWithSource": "To DataProxy, Response by Source",

Review Comment:
   Suggest changing to:
   ```
   Report to DataProxy and respond when the DataProxy received data
   Report to DataProxy and respond after DataProxy sends data
   Report to MQ and respond when the MQ received data
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org