You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "Simon Helsen (JIRA)" <ji...@apache.org> on 2011/08/11 23:04:27 UTC
[jira] [Created] (JENA-95) journal.jrl is not released when
expelling a alocation
journal.jrl is not released when expelling a alocation
------------------------------------------------------
Key: JENA-95
URL: https://issues.apache.org/jira/browse/JENA-95
Project: Jena
Issue Type: Bug
Reporter: Simon Helsen
Priority: Critical
whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
Caused by:
java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Seaborne closed JENA-95.
-----------------------------
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085046#comment-13085046 ]
Andy Seaborne commented on JENA-95:
-----------------------------------
This wasn't the original US for expel, but it seems reasonable to use it as this (rename as "release"?). No file handles should be kept.
But it does seem to work for me - I can't reproduce this. What is needed is a test case to give a sequence of TxTDB operations that leads to the situation.
The code you cite (in JournalControl.recoverNodeDat) is called only on dataset recovery. I've added dataJrnl.close() ;
Is there a recovery going on? Recovery is done if a non-empty node data journal file is found during initializing that dadaset for transactions.
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083696#comment-13083696 ]
Simon Helsen commented on JENA-95:
----------------------------------
looks like the latter is kept in a NodeTableTrans object without ever releasing it. I see the following code
ObjectFile dataJrnl = FileFactory.createObjectFileDisk(objFilename) ;
NodeTableTrans ntt = new NodeTableTrans(objFilename, baseNodeTable, new IndexMap(recordFactory), dataJrnl) ;
ntt.append() ;
ntt.close() ;
but ntt.close() does not close the dataJrnl inside the NodeTableTrans
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084175#comment-13084175 ]
Simon Helsen commented on JENA-95:
----------------------------------
Andy, I will try again with the latest build (I am using one from 0809). Comments:
1) we do not expel when transactions on that particular store are still active (at least not knowingly - perhaps there is a bug). We abort all still running queries when a shutdown is initiated
2) it is a regular use case for us to be able to be able shutdown any of our triple stores and the restart them (typical use-cases are back up, reindex, compacting, etc.), so I am not sure what you mean by "It should not be necessary to call either in regular use". What is regular for you?
3) When you say the "order of operations" seems important, what does that mean?
4) can you please comment on what I wrote in the second comment above (re: NodeTableTrans)
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086553#comment-13086553 ]
Simon Helsen commented on JENA-95:
----------------------------------
I can confirm that this issue seems to be resolved in our own tests
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085287#comment-13085287 ]
Andy Seaborne commented on JENA-95:
-----------------------------------
Paolo found the bug - it's not related to the recovery code.
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086185#comment-13086185 ]
Paolo Castagna commented on JENA-95:
------------------------------------
Thanks Andy, I am happy to see this bug closed.
I have been running TestTransSystem a few times, checking open (and deleted) file handlers and I do not see any of the problems I was seeing yesterday.
@Simon, if you want and if it helps, you can look at TestTransSystem.java in the TxTDB test suite and use it to run multiple read|write transactions concurrently. You could try changing the Writer as well when you suspect a bug in order to replicate it. I've found TestTransSystem.java quite useful lately (and I've been running it a lot!).
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086277#comment-13086277 ]
Simon Helsen commented on JENA-95:
----------------------------------
thanks guys, I'll give it a shot with build tx-tdb-0.9.0-20110817.065027-9
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085825#comment-13085825 ]
Paolo Castagna commented on JENA-95:
------------------------------------
Shouldn't we close the Journal also in Storeconnection.expel(...) method?
Index: src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java
===================================================================
--- src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java (revision 1158186)
+++ src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java (working copy)
@@ -107,6 +107,7 @@
return ;
if ( ! force && sConn.transactionManager.activeTransactions() )
throw new TDBTransactionException("Can't expel: Active transactions for location: "+location) ;
+ sConn.transactionManager.getJournal().close() ;
sConn.baseDSG.close() ;
cache.remove(location) ;
}
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084085#comment-13084085 ]
Andy Seaborne commented on JENA-95:
-----------------------------------
I've added some checking in the svn codebase - you can't expel when transactions are active; .reset is more brutal about resetting the system. It should not be necessary to call either in regular use; reset() is really only for testing to reset the system to a known, blank state.
I've not managed to recreate this. Please can you provide a @Test case and confirm which development build it's happening in?
The order of operations seems to be important. AbstractTestTransSeq now has some test cases attempting to recreate the situation but they pass (trans_50,51,52)
The latest develop build is20110811.094356-8
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086171#comment-13086171 ]
Andy Seaborne commented on JENA-95:
-----------------------------------
Proper StoreConenction.shutdown added.
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (JENA-95) journal.jrl is not released
when expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085046#comment-13085046 ]
Andy Seaborne edited comment on JENA-95 at 8/15/11 12:45 PM:
-------------------------------------------------------------
This wasn't the original US for expel, but it seems reasonable to use it as this (rename as "release"?). No file handles should be kept.
But it does seem to work for me - I can't reproduce this. What is needed is a test case to give a sequence of TxTDB operations that leads to the situation.
The code you cite (in JournalControl.recoverNodeDat) is called only on dataset recovery. I've added dataJrnl.close() in SVN.
Is there a recovery going on? Recovery is done if a non-empty node data journal file is found during initializing that dadaset for transactions. Expelling an active datset is another possibility but should be caught in the latest dev build.
was (Author: andy.seaborne):
This wasn't the original US for expel, but it seems reasonable to use it as this (rename as "release"?). No file handles should be kept.
But it does seem to work for me - I can't reproduce this. What is needed is a test case to give a sequence of TxTDB operations that leads to the situation.
The code you cite (in JournalControl.recoverNodeDat) is called only on dataset recovery. I've added dataJrnl.close() ;
Is there a recovery going on? Recovery is done if a non-empty node data journal file is found during initializing that dadaset for transactions.
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085075#comment-13085075 ]
Simon Helsen commented on JENA-95:
----------------------------------
yes, release would reflect it better. As for a test case, I understand it would help and I may get around to this, but I was currently in evaluation mode only and have other systems to test. (note that I filed other defects because I am unable to finish the evaluation).
As for recovery going on, perhaps that is a possibility, although I am not sure why since all previous transactions were closed. OTOH, I run into this around the same time the corrupted index is surfacing, which is why perhaps there is a relation. Now, even if there was a recovery going on, I would expect that the recovery is suspect when expel (or perhaps release) is invoked and restarted the next time I connect, so perhaps, if the behavior is enhanced like this, this particular problem would go away?
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084368#comment-13084368 ]
Simon Helsen commented on JENA-95:
----------------------------------
also, I wonder if there is a connection to https://issues.apache.org/jira/browse/JENA-93, i.e. could it be that a corrupted store brings TDB in a position in which it is unable to release a transaction?
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084295#comment-13084295 ]
Simon Helsen commented on JENA-95:
----------------------------------
just tried with build 20110811.094356-8 and there is no difference.
Can we agree that the expectation of StoreLocation.expel(location) is that no file handles should be kept in the location?
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083569#comment-13083569 ]
Simon Helsen commented on JENA-95:
----------------------------------
I managed to manually call
this.store.getTransMgr().getJournal().close();
although I am not sure if that is a good idea. Then I ran into the next lock:
Caused by:
java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\_fREaIL-VEeC6sfuJEYTu-w\jfs-rdfindex\nodes.dat-jrnl
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (JENA-95) journal.jrl is not released
when expelling a alocation
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085825#comment-13085825 ]
Paolo Castagna edited comment on JENA-95 at 8/16/11 4:36 PM:
-------------------------------------------------------------
Shouldn't we close the Journal also in StoreConnection.expel(...) method?
Index: src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java
===================================================================
--- src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java (revision 1158186)
+++ src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java (working copy)
@@ -107,6 +107,7 @@
return ;
if ( ! force && sConn.transactionManager.activeTransactions() )
throw new TDBTransactionException("Can't expel: Active transactions for location: "+location) ;
+ sConn.transactionManager.getJournal().close() ;
sConn.baseDSG.close() ;
cache.remove(location) ;
}
was (Author: castagna):
Shouldn't we close the Journal also in Storeconnection.expel(...) method?
Index: src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java
===================================================================
--- src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java (revision 1158186)
+++ src/main/java/com/hp/hpl/jena/tdb/StoreConnection.java (working copy)
@@ -107,6 +107,7 @@
return ;
if ( ! force && sConn.transactionManager.activeTransactions() )
throw new TDBTransactionException("Can't expel: Active transactions for location: "+location) ;
+ sConn.transactionManager.getJournal().close() ;
sConn.baseDSG.close() ;
cache.remove(location) ;
}
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Simon Helsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Helsen updated JENA-95:
-----------------------------
Component/s: TDB
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JENA-95) journal.jrl is not released when
expelling a alocation
Posted by "Andy Seaborne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JENA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Seaborne resolved JENA-95.
-------------------------------
Resolution: Fixed
Assignee: Andy Seaborne
SVN updated with fix.
> journal.jrl is not released when expelling a alocation
> ------------------------------------------------------
>
> Key: JENA-95
> URL: https://issues.apache.org/jira/browse/JENA-95
> Project: Jena
> Issue Type: Bug
> Components: TDB
> Reporter: Simon Helsen
> Assignee: Andy Seaborne
> Priority: Critical
>
> whenever I call StoreConnection.expel(location) it seems that something is holding on to journal.jrl in location
> Caused by:
> java.io.IOException: Could not delete D:\jfsDev\working_dir\indices\4cb718ffab6047639c383cf9582633dc\jfs-rdfindex\journal.jrnl
> at java.lang.Throwable.<init>(Throwable.java:67)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira