You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/30 18:27:22 UTC
[GitHub] codecov-io edited a comment on issue #6722: Add "Select All" to
SelectControl and allow free form group by expressions
codecov-io edited a comment on issue #6722: Add "Select All" to SelectControl and allow free form group by expressions
URL: https://github.com/apache/incubator-superset/pull/6722#issuecomment-456269042
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=h1) Report
> Merging [#6722](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/11a7ad00b7c44785752bf23ef90bcf4ebb58598e?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `50.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6722 +/- ##
==========================================
- Coverage 56.07% 56.04% -0.04%
==========================================
Files 526 525 -1
Lines 23257 23255 -2
Branches 2782 2783 +1
==========================================
- Hits 13042 13033 -9
- Misses 9806 9813 +7
Partials 409 409
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.4% <0%> (-0.35%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.08% <100%> (-0.09%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.71% <100%> (+0.01%)` | :arrow_up: |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU2VsZWN0Q29udHJvbC5qc3g=) | `61.44% <44.68%> (-16.56%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `54.08% <0%> (-0.03%)` | :arrow_down: |
| [superset/assets/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2V4cGxvcmVVdGlscy5qcw==) | `80.85% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy91dGlscy9zYWZlU3RyaW5naWZ5LnRz) | | |
| [superset/assets/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydFJlZHVjZXIuanM=) | `22.5% <0%> (+0.27%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/6722/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=footer). Last update [11a7ad0...ffd8ad0](https://codecov.io/gh/apache/incubator-superset/pull/6722?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org