You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/19 03:01:23 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #35575: [SPARK-38121][PYTHON][SQL][FOLLOW-UP] Make df.sparkSession return the session that created DataFrame when SQLContext is used.

HyukjinKwon opened a new pull request #35575:
URL: https://github.com/apache/spark/pull/35575


   ### What changes were proposed in this pull request?
   
   This PR is a followup of https://github.com/apache/spark/pull/35410 that makes `df.sparkSession` return the session that created DataFrame when `SQLContext` is used.
   
   ### Why are the changes needed?
   
   See https://github.com/apache/spark/pull/35410#discussion_r810431358
   
   ### Does this PR introduce _any_ user-facing change?
   
   No to end users as it's not released yet. See also https://github.com/apache/spark/pull/35410#discussion_r810431358
   
   
   ### How was this patch tested?
   
   ```python
   >>> from pyspark.sql import DataFrame
   >>> DataFrame(sqlContext.range(1)._jdf, sqlContext).sparkSession
   /.../spark/python/pyspark/sql/dataframe.py:127: UserWarning: DataFrame constructor is internal. Do not directly use it.
     warnings.warn("DataFrame constructor is internal. Do not directly use it.")
   <pyspark.sql.session.SparkSession object at 0x7fa7483972b0>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #35575: [SPARK-38121][PYTHON][SQL][FOLLOW-UP] Make df.sparkSession return the session that created DataFrame when SQLContext is used

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35575:
URL: https://github.com/apache/spark/pull/35575


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35575: [SPARK-38121][PYTHON][SQL][FOLLOW-UP] Make df.sparkSession return the session that created DataFrame when SQLContext is used

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35575:
URL: https://github.com/apache/spark/pull/35575#issuecomment-1048333718


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35575: [SPARK-38121][PYTHON][SQL][FOLLOW-UP] Make df.sparkSession return the session that created DataFrame when SQLContext is used

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35575:
URL: https://github.com/apache/spark/pull/35575#issuecomment-1047335782


   cc @zsxwing mind taking a quick look please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org