You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/11/02 11:10:51 UTC

[GitHub] [couchdb-nano] insidewhy opened a new pull request, #311: fix typing of 'since' options

insidewhy opened a new pull request, #311:
URL: https://github.com/apache/couchdb-nano/pull/311

   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## GitHub issue number
   
   <!-- If this is a significant change, please file a separate issue at:
        https://github.com/apache/couchdb-nano/issues
        and include the number here and in commit message(s) using
        syntax like "Fixes #472" or "Fixes apache/couchdb#472".  -->
   
   ## Related Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] insidewhy commented on a diff in pull request #311: fix typing of 'since' options

Posted by GitBox <gi...@apache.org>.
insidewhy commented on code in PR #311:
URL: https://github.com/apache/couchdb-nano/pull/311#discussion_r1011584073


##########
lib/nano.d.ts:
##########
@@ -248,7 +248,7 @@ declare namespace nano {
     /** whether to get a faster changes feed by supplying 'seq_interval'   */
     fastChanges?: boolean;
     /** where to begin the changes feed: 0, now or a sequence token */
-    since?: string;
+    since?: string | number;

Review Comment:
   `0` is accepted so added `| number`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #311: fix typing of 'since' options

Posted by GitBox <gi...@apache.org>.
glynnbird merged PR #311:
URL: https://github.com/apache/couchdb-nano/pull/311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] insidewhy commented on a diff in pull request #311: fix typing of 'since' options

Posted by GitBox <gi...@apache.org>.
insidewhy commented on code in PR #311:
URL: https://github.com/apache/couchdb-nano/pull/311#discussion_r1011584644


##########
lib/nano.d.ts:
##########
@@ -965,7 +965,7 @@ declare namespace nano {
      * Can be valid update sequence or now value.
      *
      * @default 0 */
-    since?: number;
+    since?: string | number;

Review Comment:
   `now` and sequences can be accepted, so added `string |`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird commented on a diff in pull request #311: fix typing of 'since' options

Posted by GitBox <gi...@apache.org>.
glynnbird commented on code in PR #311:
URL: https://github.com/apache/couchdb-nano/pull/311#discussion_r1012668093


##########
lib/nano.d.ts:
##########
@@ -248,7 +248,7 @@ declare namespace nano {
     /** whether to get a faster changes feed by supplying 'seq_interval'   */
     fastChanges?: boolean;
     /** where to begin the changes feed: 0, now or a sequence token */
-    since?: string;
+    since?: string | number;

Review Comment:
   Yeah "since" is a bit of a nightmare isn't it? :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org