[GitHub] [dubbo] EarthChen commented on a diff in pull request #10726: Enqueue soon

[GitBox <gi...@apache.org>]

EarthChen commented on code in PR #10726:
URL: https://github.com/apache/dubbo/pull/10726#discussion_r1014597381


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/command/FrameQueueCommand.java:
##########
@@ -18,15 +18,25 @@
 package org.apache.dubbo.rpc.protocol.tri.command;
 
 import io.netty.channel.Channel;
-import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.ChannelPromise;
+import io.netty.handler.codec.http2.Http2StreamFrame;
 
-public abstract class QueuedCommand {
+public class FrameQueueCommand {

Review Comment:
   I recommend that the different child cmd not be deleted, the design is used to mask the h2 data structure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org