You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/26 11:00:18 UTC

[PR] fix(setup): ship the read-only allow set to adopters; allow both vetted-op-read forms [magpie]

potiuk opened a new pull request, #1393:
URL: https://github.com/apache/magpie/pull/1393

   ## Summary
   
   - **Adopters never received the read-only allow set.** The adopter install prompt copied `sandbox`, `permissions.deny` and `permissions.ask` from the framework settings, but not `permissions.allow`, and the update check never diffed it. In an installed tracker repo, every `gh` read, archive read and mailbox read the security skills make prompted. One bulk `security-issue-sync` over ~40 trackers produced several hundred read-only prompts. Install now copies `permissions.allow` (read-only entries only), and update reports every missing read-only entry as a prompt the user is paying for.
   - **The `vetted-op-read` default matched only one invocation form.** Skills document `uv run --project …/vetted-ops vetted-op-read`, while read-only gatherer agents use `uvx --from …/vetted-ops vetted-op-read`, because `uv run` in the plugin cache has to write a venv there. Only the `uv run` form was sandbox-excluded, and neither form was in the framework's own `permissions.allow`. Both forms are now allowed and excluded. The write dispatcher (`vetted-op`) stays on `ask`.
   - **Adds the missing read-only MCP tools and registry fetches** to the default set: PonyMail `get_source` / `list_lists`, Gmail `get_message` / `list_drafts` / `get_draft`, `gmail-plaintext` `check_auth`, apache-projects `get_releases` / `get_repositories` / `list_committees` / `search_projects`, and `WebFetch` for `cveawg.mitre.org`, `pypi.org` and `lists.apache.org`.
   
   ## Type of change
   
   - [x] Skill change (`.claude/skills/<name>/`) — `isolated-setup-install`, `isolated-setup-update`
   - [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`) — `secure-agent-setup.md` template, install and update prompts
   - [x] CI / dev loop (`prek`, workflows, validators) — `.claude/settings.json` + `tools/sandbox-lint/expected.json` kept in lockstep; new sandbox-lint tests
   
   ## Test plan
   
   - [x] `prek run --all-files` passes
   - [x] `uv run --directory tools/sandbox-lint pytest -q` passes, including new tests: both `vetted-op-read` forms must be in `allow` and `excludedCommands`, and the `vetted-op` write dispatcher must never be in `allow`. Both fail on `main`.
   - [x] `sandbox-lint`: `.claude/settings.json` matches `expected.json`
   
   ## RFC-AI-0004 compliance
   
   - [x] **HITL** — only read-only operations move to `allow`. Every write keeps its prompt: `gh` writes, `gh api *`, `vetted-op`, `git push`, PonyMail `login`, Gmail mutations. The one draft tool already in the baseline, `gmail-plaintext` `create_draft`, only creates an unsent draft.
   - [x] **Sandbox** — the new `excludedCommands` entry is the same read-only dispatcher already excluded in its `uv run` form. Its catalogue stays `Edit`-denied and outside every `allowWrite` root.
   
   ## Notes for reviewers (optional)
   
   `uvx --from` is the form that actually works for a sandboxed adopter: `uv run --project` against the versioned plugin cache wants to create `.venv` inside it, and the cache is (correctly) not writable. Whether the skills should switch their documented form to `uvx --from` is a separate change; this PR only makes both forms prompt-free.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(setup): ship the read-only allow set to adopters; allow both vetted-op-read forms [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1393:
URL: https://github.com/apache/magpie/pull/1393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org