[jira] [Commented] (TAP5-2478) Create getIfExists in SessionApplicationStatePersistenceStrategy

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385766#comment-15385766 ] 

Jochen Kemnade commented on TAP5-2478:
--------------------------------------

This is problematic because it introduces a method in a public interface ({{org.apache.tapestry5.services.ApplicationStatePersistenceStrategy}}).

> Create getIfExists in SessionApplicationStatePersistenceStrategy
> ----------------------------------------------------------------
>
>                 Key: TAP5-2478
>                 URL: https://issues.apache.org/jira/browse/TAP5-2478
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Maria Fedotova
>              Labels: patch, perfomance
>         Attachments: TAP5-2478.patch, TAP5-2478_add.patch
>
>
> Instead of this code
> {code}
> public <T> T getIfExists(Class<T> ssoClass)
>     {
>         ApplicationStateAdapter<T> adapter = getAdapter(ssoClass);
>         return adapter.exists() ? adapter.getOrCreate() : null;
>     }
> {code}
> I've create function getIfExists
> {code}
>     public <T> T getIfExists(Class<T> ssoClass)
>     {
>         return getAdapter(ssoClass).getIfExists();
>     }
> {code}
> This patch increased requests per second on ~7% (from 24 to 26 on huge pages)
> Thank [~mihasik] for the idea.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)