You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/18 22:14:25 UTC
[GitHub] [flink] xuefuz commented on a change in pull request #10241:
[FLINK-14842][table] add logging for loaded modules and functions
xuefuz commented on a change in pull request #10241: [FLINK-14842][table] add logging for loaded modules and functions
URL: https://github.com/apache/flink/pull/10241#discussion_r347637095
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleManager.java
##########
@@ -37,6 +42,9 @@
* Responsible for loading/unloading modules, managing their life cycles, and resolving module objects.
*/
public class ModuleManager {
+
+ private static final Logger LOG = LoggerFactory.getLogger(CatalogManager.class);
Review comment:
Should ModuleManager have its own logger?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services