You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/15 09:46:11 UTC

[GitHub] [flink] luoyuxia commented on a diff in pull request #19424: [FLINK-22732][table] Restrict ALTER TABLE from setting empty table op…

luoyuxia commented on code in PR #19424:
URL: https://github.com/apache/flink/pull/19424#discussion_r851182447


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java:
##########
@@ -547,6 +547,12 @@ private Operation convertAlterTableOptions(
             ObjectIdentifier tableIdentifier,
             CatalogTable oldTable,
             SqlAlterTableOptions alterTableOptions) {
+        Map<String, String> setOptions =

Review Comment:
   Will it be better to do the validation when parse `alter table set` in `parserImpls.ftl`
   For me,  it looks like a restriction in sql synax level.  From my sense, `alter table cat1.db1.tb1 set ()` is like a illegal sql.
   Anyway, looks good to me for  either way .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org