[jira] [Commented] (PHOENIX-5316) Use callable instead of runnable so that Pherf exceptions cause tests to fail

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856255#comment-16856255 ] 

Hadoop QA commented on PHOENIX-5316:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12970891/PHOENIX-5316-4.x-HBase-1.3.patch
  against 4.x-HBase-1.3 branch at commit 27bc7140de826929fdad4c4027b609dc20b0dbe3.
  ATTACHMENT ID: 12970891

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            ParseNode defaultParseNode = new SQLParser(column. getExpressionStr()).parseExpression();
+                        Preconditions.checkArgument((minInt >= -128) && (minInt <= 128), "min value need to be set in configuration for tinyints " + column.getName());
+                        Preconditions.checkArgument((maxInt >= -128) && (maxInt <= 128), "max value need to be set in configuration for tinyints " + column.getName());
+                        Preconditions.checkArgument((minLong > 0) && (maxLong > 0), "min and max values need to be set in configuration for unsigned_longs " + column.getName());
+            QuerySetResult querySetResult, Scenario scenario) throws ExecutionException, InterruptedException {
+            QuerySetResult querySetResult, Scenario scenario) throws ExecutionException, InterruptedException {
+                <ddl statement="CREATE INDEX IDX_DIVISION ON PHERF.PHERF_PROD_TEST_UNSALTED (DIVISION)"/>
+                <ddl statement="CREATE INDEX IDX_OLDVAL_STRING ON PHERF.PHERF_PROD_TEST_UNSALTED (OLDVAL_STRING)"/>
+                <ddl statement="CREATE INDEX IDX_CONNECTION_ID ON PHERF.PHERF_PROD_TEST_UNSALTED (CONNECTION_ID)"/>

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2622//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2622//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2622//console

This message is automatically generated.

> Use callable instead of runnable so that Pherf exceptions cause tests to fail
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5316
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5316
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>              Labels: pherf
>         Attachments: PHOENIX-5316-4.x-HBase-1.3.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Also add support for BIGINT and TINYINT. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)