You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/04/07 03:54:41 UTC
Review Request 45853: Removed 'dashboard.js' from the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45853/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-5137
https://issues.apache.org/jira/browse/MESOS-5137
Repository: mesos
Description
-------
This file is no longer referenced anywhere in the webui and none of
the functions it defines are called anywhere.
Diffs
-----
src/webui/master/static/js/dashboard.js d6cbb3cc5aa92249c4b17c6d77260b215203d008
Diff: https://reviews.apache.org/r/45853/diff/
Testing
-------
The webui still appears to work in all respects without this file.
Thanks,
Kevin Klues
Re: Review Request 45853: Removed 'dashboard.js' from the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45853/#review127860
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45853/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 1:54 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-5137
> https://issues.apache.org/jira/browse/MESOS-5137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This file is no longer referenced anywhere in the webui and none of
> the functions it defines are called anywhere.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/dashboard.js d6cbb3cc5aa92249c4b17c6d77260b215203d008
>
> Diff: https://reviews.apache.org/r/45853/diff/
>
>
> Testing
> -------
>
> The webui still appears to work in all respects without this file.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 45853: Removed 'dashboard.js' from the webui.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45853/#review127532
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45853/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 1:54 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-5137
> https://issues.apache.org/jira/browse/MESOS-5137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This file is no longer referenced anywhere in the webui and none of
> the functions it defines are called anywhere.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/dashboard.js d6cbb3cc5aa92249c4b17c6d77260b215203d008
>
> Diff: https://reviews.apache.org/r/45853/diff/
>
>
> Testing
> -------
>
> The webui still appears to work in all respects without this file.
>
>
> Thanks,
>
> Kevin Klues
>
>