You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "xiechimon (via GitHub)" <gi...@apache.org> on 2026/09/16 02:58:26 UTC
Re: [PR] feat(cli): add Korean catalog for TUI [maka]
xiechimon commented on PR #4349:
URL: https://github.com/apache/maka/pull/4349#issuecomment-5691375016
The Korean work has consolidated into the #5100 stack, and #4515 already moves `tui-copy-catalog.test.ts` to the `resolveUiMessageCatalog` contract. #4349 is still based on main and uses the older `getKoCatalog` cast, so it conflicts with both.
The CLI/TUI catalog domains from #3979 (mcp-status, pickers, primary-guidance, session-status) aren't covered anywhere else. #4515's `add-ko-catalog-stub.mjs` doesn't list `tui-copy-catalog.ts`, so the Korean copy for those four domains is still open.
Before I redo it: should #4349 rebase onto #5100 and adopt the new test contract, or do you want it folded into a different slice? I'd rather match the stack than land it standalone on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org