You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/09 02:49:52 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #38570: [SPARK-41056][R] Fix new R_LIBS_SITE behavior introduced in R 4.2

HyukjinKwon opened a new pull request, #38570:
URL: https://github.com/apache/spark/pull/38570

   ### What changes were proposed in this pull request?
   
   This PR proposes to keep the `R_LIBS_SITE` as was. It has been changed from R 4.2.
   
   ### Why are the changes needed?
   
   To keep the behaviour same as the previous. This especially affects the external libraries installed in SparkR worker sides. Especially this can break the user-installed libraries. See the paths below:
   
   **R 4.2**
   
   ```
   # R
   > Sys.getenv("R_LIBS_SITE")
   [1] "/usr/local/lib/R/site-library/:/usr/lib/R/site-library:/usr/lib/R/library'"
   # R --vanilla
   > Sys.getenv("R_LIBS_SITE")
   [1] "/usr/lib/R/site-library"
   ```
   
   **R 4.1**
   
   ```
   # R
   > Sys.getenv("R_LIBS_SITE")
   [1] "/usr/local/lib/R/site-library:/usr/lib/R/site-library:/usr/lib/R/library"
   # R --vanilla
   > Sys.getenv("R_LIBS_SITE")
   [1] "/usr/local/lib/R/site-library:/usr/lib/R/site-library:/usr/lib/R/library"
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. With R 4.2, user-installed libraries won't be found in SparkR workers.
   
   ### How was this patch tested?
   
   Manually tested, unittest added. It's difficult to add an e2e tests.
   
   I also manually tested `getROptions` in Scala shall.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #38570: [SPARK-41056][R] Fix new R_LIBS_SITE behavior introduced in R 4.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38570:
URL: https://github.com/apache/spark/pull/38570#issuecomment-1308338748

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #38570: [SPARK-41056][R] Fix new R_LIBS_SITE behavior introduced in R 4.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38570: [SPARK-41056][R] Fix new R_LIBS_SITE behavior introduced in R 4.2
URL: https://github.com/apache/spark/pull/38570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #38570: [SPARK-41056][R] Fix new R_LIBS_SITE behavior introduced in R 4.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38570:
URL: https://github.com/apache/spark/pull/38570#issuecomment-1308337531

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org