You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/10/10 10:01:52 UTC
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request
#2861: ARTEMIS-2515 pageIterator.hasNext spends too much time in the case
of no messages matched
franz1981 commented on a change in pull request #2861: ARTEMIS-2515 pageIterator.hasNext spends too much time in the case of no messages matched
URL: https://github.com/apache/activemq-artemis/pull/2861#discussion_r333434047
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
##########
@@ -1323,7 +1328,13 @@ private PagedReference moveNext() {
PagePositionAndFileOffset lastPosition = position;
PagePositionAndFileOffset tmpPosition = position;
+ long timeout = System.currentTimeMillis() + DELIVERY_TIMEOUT;
Review comment:
Use nanoTime here that is not susceptible to NTP updates :)
Now I can return to my honeymoon :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services