[jira] [Commented] (PDFBOX-5270) Consider BaseParser.seqSource a protected member

["Andreas Lehmkühler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409954#comment-17409954 ] 

Andreas Lehmkühler commented on PDFBOX-5270:
--------------------------------------------

This change is part of the refactoring in 3.0.0. 

> Consider BaseParser.seqSource a protected member
> ------------------------------------------------
>
>                 Key: PDFBOX-5270
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5270
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Text extraction
>    Affects Versions: 2.0.24
>            Reporter: Alistair Oldfield
>            Assignee: Andreas Lehmkühler
>            Priority: Minor
>
> Please consider making 
> org.apache.pdfbox.pdfparser.BaseParser.seqSource a protected member.
> i.e.
>  
> {code:java}
> protected final SequentialSource seqSource;
>  
> {code}
> this will allow extending the PDFStreamParser class to make use of the seqSource.
>  
> In my particular case (only to show one of many possible use-cases), I do not want to skip comments in the PDF stream:
> {code:java}
> %comment in stream which may be useful to read{code}
>  
> One cannot usefully override 
>  
> {code:java}
> protected void skipSpaces() throws IOException
>  
> {code}
>  
> without access to this member.
>  
> As the skipSpaces is already protected, it implies that one may find it useful to override it anyway (probably other reasons too, but is not really meaningful without access to seqSource).
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org