You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/11 07:30:47 UTC
[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request
#5148: remove stale functions
strongduanmu opened a new pull request #5148: remove stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5148
Fixes #5136 .
Changes proposed in this pull request:
- remove the stale functions in PostgreSQLDMLVisitor, MySQLDMLVisitor, OracleDMLVisitor, SQLServerDMLVisitor and SQL92DMLVisitor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5148:
remove stale functions
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5148: remove stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5148#issuecomment-612371505
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=h1) Report
> Merging [#5148](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/c83b994cf26f62a4d6799e397a0256be7c404b71&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5148 +/- ##
============================================
- Coverage 53.84% 53.73% -0.12%
Complexity 401 401
============================================
Files 1148 1150 +2
Lines 20515 20904 +389
Branches 3703 3790 +87
============================================
+ Hits 11046 11232 +186
- Misses 8783 8971 +188
- Partials 686 701 +15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sql/parser/mysql/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2ltcGwvTXlTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...l/parser/oracle/visitor/impl/OracleDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvaW1wbC9PcmFjbGVETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...sql/parser/sql92/visitor/impl/SQL92DMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL2ltcGwvU1FMOTJETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/sqlserver/visitor/impl/SQLServerDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvaW1wbC9TUUxTZXJ2ZXJETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...jdbc/core/statement/ShardingPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `72.18% <0.00%> (-0.32%)` | `0.00% <0.00%> (ø%)` | |
| [...rdingsphere/underlying/executor/log/SQLLogger.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1leGVjdXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdW5kZXJseWluZy9leGVjdXRvci9sb2cvU1FMTG9nZ2VyLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9KREJDRGF0YWJhc2VDb21tdW5pY2F0aW9uRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...sctl/explain/ShardingCTLExplainBackendHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvc2N0bC9leHBsYWluL1NoYXJkaW5nQ1RMRXhwbGFpbkJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../underlying/executor/context/ExecutionContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1leGVjdXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdW5kZXJseWluZy9leGVjdXRvci9jb250ZXh0L0V4ZWN1dGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=footer). Last update [c83b994...b9bfbee](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #5148:
remove stale functions
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #5148: remove stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5148#issuecomment-612555086
> @strongduanmu Hi thanks for your contribution, However, there are more stale functions existed in those classes. Could you check them again? It seems another contribution is expected.
@tristaZero I'm so sorry for this, I will check again.😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5148:
remove stale functions
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5148: remove stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #5148:
remove stale functions
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5148: remove stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5148#issuecomment-612552962
@strongduanmu Hi thanks for your contribution, However, there are more stale functions existed in those classes. Could you check them again? It seems another contribution is expected. 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5148:
remove stale functions
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5148: remove stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5148#issuecomment-612372625
## Pull Request Test Coverage Report for [Build 10981](https://coveralls.io/builds/30008968)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.04%**) to **57.281%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/30008968/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L286) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/30008968) |
| :-- | --: |
| Change from base [Build 10980](https://coveralls.io/builds/30008856): | 0.04% |
| Covered Lines: | 11758 |
| Relevant Lines: | 20527 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services