You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by GitBox <gi...@apache.org> on 2021/02/21 17:52:31 UTC
[GitHub] [db-jdo-site] tobous opened a new pull request #29: Use icons with highest resolution available for website
tobous opened a new pull request #29:
URL: https://github.com/apache/db-jdo-site/pull/29
Adjusts the website to use the 150x150 version of the JDO logo instead
of smaller ones. Sets the scaling manually to keep the previous size
when using the larger image.
Adjusts the image size of the header icon to better fit the bar and
create an even spacing with the default layout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] clr-apache commented on pull request #29: Use icons with highest resolution available for website
Posted by GitBox <gi...@apache.org>.
clr-apache commented on pull request #29:
URL: https://github.com/apache/db-jdo-site/pull/29#issuecomment-782916960
It's good to use higher resolution images on the site, so LGTM.
I can't see much difference between 45.5 and 45, so I will defer to your judgement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tobous commented on pull request #29: Use icons with highest resolution available for website
Posted by GitBox <gi...@apache.org>.
tobous commented on pull request #29:
URL: https://github.com/apache/db-jdo-site/pull/29#issuecomment-783272883
As the last usage of the icon, I also replaced the icon displayed in the tab with the 150x150 pixel one. Here is a comparison with the previous version on the left and the new version on the right is given below. While the icon looks a bit "smaller" after the change (as the higher res one includes a white border) and the resolution difference is hardly noticeable when displayed as the tab icon, the higher resolution is very much noticeable when the icon is displayed in a larger size (e.g. when creating a shortcut for the page in chrome, which uses the same icon as the tab icon).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tobous commented on pull request #29: Use icons with highest resolution available for website
Posted by GitBox <gi...@apache.org>.
tobous commented on pull request #29:
URL: https://github.com/apache/db-jdo-site/pull/29#issuecomment-782897260
I chose the new size for the header icon to best fit the layout. The width of 45.5 is kind of weird, but the bar has the size ~51 by default. Below is a comparison of width 45 and 45.5. The previous size of 44 can be observed on the current size. I personally like 45.5 best, which is why I used it in the PR. But if you prefer another size, I can change it.
45:
45.5:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] clr-apache commented on pull request #29: Use icons with highest resolution available for website
Posted by GitBox <gi...@apache.org>.
clr-apache commented on pull request #29:
URL: https://github.com/apache/db-jdo-site/pull/29#issuecomment-783618580
I've looked in my records and cannot find any record of the original icon, who made it, or the source code to it. :(
I'll try again later...
Craig
> On Feb 22, 2021, at 2:32 AM, Tobias Bouschen <no...@github.com> wrote:
>
>
> As the last usage of the icon, I also replaced the icon displayed in the tab with the 150x150 pixel one. Here is a comparison with the previous version on the left and the new version on the right is given below. While the icon looks a bit "smaller" after the change (as the higher res one includes a white border) and the resolution difference is hardly noticeable when displayed as the tab icon, the higher resolution is very much noticeable when the icon is displayed in a larger size (e.g. when creating a shortcut for the page in chrome, which uses the same icon as the tab icon).
>
> <https://user-images.githubusercontent.com/12495415/108695796-fec97f00-7500-11eb-940f-a47a38a9ce00.png>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/apache/db-jdo-site/pull/29#issuecomment-783272883>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RB5WVVLP2ZS7VUGSK3TAIXFFANCNFSM4X7GTKUA>.
>
Craig L Russell
clr@apache.org
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tobous merged pull request #29: Use icons with highest resolution available for website
Posted by GitBox <gi...@apache.org>.
tobous merged pull request #29:
URL: https://github.com/apache/db-jdo-site/pull/29
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org