[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1910: Resolve IP option for Nodetool gossiping command

[GitBox <gi...@apache.org>]

smiklosovic commented on code in PR #1910:
URL: https://github.com/apache/cassandra/pull/1910#discussion_r995451648


##########
src/java/org/apache/cassandra/gms/FailureDetector.java:
##########
@@ -107,20 +107,35 @@ private static long getInitialValue()
 
     public String getAllEndpointStates()
     {
-        return getAllEndpointStates(false);
+        return getAllEndpointStates(false, false);
+    }
+
+    public String getAllEndpointStatesWithResolveIp()

Review Comment:
   should not it be "...WithResolvedIp()" ? Notice "Resolved" instead of "Resolve". This change should be applicable everywhere in this patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org