You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/01 18:53:57 UTC
[GitHub] [apisix] leslie-tsang opened a new pull request #5391: Feat/eclint
leslie-tsang opened a new pull request #5391:
URL: https://github.com/apache/apisix/pull/5391
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Ref to #5346
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5391: feat: add eclint support
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5391:
URL: https://github.com/apache/apisix/pull/5391#discussion_r740700060
##########
File path: .github/workflows/ci-eclint.yml
##########
@@ -0,0 +1,32 @@
+name: ci-eclint
Review comment:
It would be great if we can add it to https://github.com/apache/apisix/blob/042ce5c1a6a4e040d6d6924f2d86e5534b730134/.github/workflows/lint.yml#L5, so that we can reduce the number of workflows we need to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5391: feat: add eclint support
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5391:
URL: https://github.com/apache/apisix/pull/5391#discussion_r740700060
##########
File path: .github/workflows/ci-eclint.yml
##########
@@ -0,0 +1,32 @@
+name: ci-eclint
Review comment:
It would be great if we can add it to https://github.com/apache/apisix/blob/042ce5c1a6a4e040d6d6924f2d86e5534b730134/.github/workflows/lint.yml#L5, so that we can reduce the number of workflows we need to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5391: ci: lint for editorconfig
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5391:
URL: https://github.com/apache/apisix/pull/5391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5391: ci: lint for editorconfig
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5391:
URL: https://github.com/apache/apisix/pull/5391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5391: feat: add eclint support
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5391:
URL: https://github.com/apache/apisix/pull/5391#discussion_r740700060
##########
File path: .github/workflows/ci-eclint.yml
##########
@@ -0,0 +1,32 @@
+name: ci-eclint
Review comment:
It would be great if we can add it to https://github.com/apache/apisix/blob/042ce5c1a6a4e040d6d6924f2d86e5534b730134/.github/workflows/lint.yml#L5, so that we can reduce the number of workflows we need to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5391: ci: lint for editorconfig
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5391:
URL: https://github.com/apache/apisix/pull/5391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org