You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/24 13:34:56 UTC

[GitHub] [flink] xintongsong opened a new pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

xintongsong opened a new pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics
URL: https://github.com/apache/flink/pull/9760
 
 
   ## What is the purpose of the change
   This PR is part of FLIP-49. It implements the new task executor memory configuration and calculation logics.
   
   ## Brief change log
   - c16e4e4: Rename constant names for managed memory size and fraction config options. This is to avoid naming conflicts in the next commit.
   - 8b201b7: Introduce task executor memory config options for FLIP-49.
   - ea4e0a0: Introduce arithmetic operations (add, subtract and multiply) for MemorySize. These are used for memory calculations in following commits.
   - a5cb8d9: Introduce 'TaskExecutorResourceSpec' as the data structure for storing calculated memory sizes.
   - fd67592: Introduce 'TaskExecutorResourceUtils' for calculating memory sizes from configurations.
   - e0a5044: Implement generating dynamic configurations ('-D' options) from 'TaskExecutorResourceSpec' in 'TaskExecutorResourceUtils'. Dynamic configurations will later be used for passing calculated memory sizes into task executors.
   - 5c24884: Implement generating JVM parameters from 'TaskExecutorResourceSpec' in 'TaskExecutorResourceUtils'. It will later be used for launching task executor JVM with calculated memory sizes.
   - 6bc9773: Add 'TaskExecutorResourceUtilsTest' that validates the memory calculation logics, dynamic configurations generation, and JVM parameters generation
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   - Add 'TaskExecutorResourceUtilsTest' that validates:
     - Memory calculation logics
     - Generating dynamic configurations
     - Generating JVM parameters
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services