[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

[GitBox <gi...@apache.org>]

martinzink commented on PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#issuecomment-1354508485

   This will be a great addition for our debugging capabilities. :+1: 
   
   
   I've found some constructors where the passing of the uuid is still missing:
   [SSLContextService](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/libminifi/include/controllers/SSLContextService.h#L93) 
   [ThreadManagementService](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/libminifi/include/controllers/ThreadManagementService.h#L41-L46)
   [ListenSyslog](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/standard-processors/processors/ListenSyslog.h#L34)
   [ConsumeWindowsEventLog](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/windows-event-log/ConsumeWindowsEventLog.cpp#L182)
   [CollectorInitiatedSubscription](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/windows-event-log/CollectorInitiatedSubscription.cpp#L163)
   [DeleteAzureDataLakeStorage](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/azure/processors/DeleteAzureDataLakeStorage.h#L52)
   [FetchAzureDataLakeStorage](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/azure/processors/FetchAzureDataLakeStorage.h#L60)
   [StandardControllerServiceNode](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/libminifi/include/core/controller/StandardControllerServiceNode.h#L37-L43)
   [StandardControllerServiceProvider](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/libminifi/include/core/controller/StandardControllerServiceProvider.h#L52-L62)
   (maybe we could refactor some of these so the logger_ isnt initialized in the ctors but rather where it is declared)
   
   also the tensorflow processors [TFApplyGraph](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/tensorflow/TFApplyGraph.h#L35), [TFConvertImageToTensor](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/tensorflow/TFConvertImageToTensor.h#L35), [TFExtractTopLabels](https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-1948_Include-Processor-UUID-in-logs/extensions/tensorflow/TFExtractTopLabels.h#L35) (not sure if we want to do these since these are not really maintained anymore and they might not even compile anymore)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org