[GitHub] [ozone] JyotinderSingh commented on a diff in pull request #3544: HDDS-6934. OM crashed with OzoneManagerDoubleBuffer

[GitBox <gi...@apache.org>]

JyotinderSingh commented on code in PR #3544:
URL: https://github.com/apache/ozone/pull/3544#discussion_r906766847


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeysDeleteResponseWithFSO.java:
##########
@@ -44,14 +44,16 @@
 public class OMKeysDeleteResponseWithFSO extends OMKeysDeleteResponse {
 
   private List<OmKeyInfo> dirsList;
+  private long volumeId;
 
   public OMKeysDeleteResponseWithFSO(
       @NotNull OzoneManagerProtocolProtos.OMResponse omResponse,
       @NotNull List<OmKeyInfo> keyDeleteList,
       @NotNull List<OmKeyInfo> dirDeleteList, boolean isRatisEnabled,
-      @NotNull OmBucketInfo omBucketInfo) {
+      @NotNull OmBucketInfo omBucketInfo, long volId) {

Review Comment:
   I don't think we will have cases of this class being instantiated with a `null` value assigned to `volId` parameter due to the changes in `getVolumeId` and `getBucketId` methods. Should we annotate it with `@NonNull` as well? (Similarly for the other request classes as well)
   ```suggestion
         @NotNull OmBucketInfo omBucketInfo, @NotNull long volId) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org