[jira] [Commented] (KYLIN-2239) Remove refresh buildType

["Shaofeng SHI (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739755#comment-15739755 ] 

Shaofeng SHI commented on KYLIN-2239:
-------------------------------------

I think "build" and "refresh" are still have difference in the scenario: one is to build new data, the other is to build history data. The checks for them are different; 

Besides, in the streaming case, the input for these two types are different: for "build", user need to specify the partition-specific offsets (unless using the reserved "0" and Long.MAX_VALUE); for "refresh", user only need specify the summed offsets. 



> Remove refresh buildType
> ------------------------
>
>                 Key: KYLIN-2239
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2239
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: kangkaisen
>            Assignee: kangkaisen
>            Priority: Minor
>
> currently, we have three build types：build, refresh, merge.  But the build and the refresh type only is one job type indeed and the build type could replace the refresh type completely. 
> So, I think the refresh type is redundant. we can firstly remove  refreshSegment in JobService internal and keep the web api unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)