You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/10 23:09:09 UTC

[GitHub] [solr] HoustonPutman commented on a change in pull request #509: SOLR-14858: Add docker test for the prometheus exporter

HoustonPutman commented on a change in pull request #509:
URL: https://github.com/apache/solr/pull/509#discussion_r781642736



##########
File path: solr/contrib/prometheus-exporter/bin/solr-exporter
##########
@@ -86,6 +86,10 @@ for JAR in $(find "$BASEDIR"/../../dist -name 'solr-solrj-*.jar')
 do
   CLASSPATH="$CLASSPATH":"$JAR"
 done
+for JAR in $(find "$BASEDIR"/../../server/solr-webapp/webapp/WEB-INF/lib/ -name '*.jar')
+do
+  CLASSPATH="$CLASSPATH":"$JAR"

Review comment:
       I can actually change most of them to wildcards. Look at the new CLASSPATH usage and let me know what you think.
   
   Note this actually removes an error line from `find` when running in Docker (because the solrj-libs dir is deleted). 🎉 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org