You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/01/17 20:15:00 UTC

[jira] [Commented] (THRIFT-2790) thrift -gen all => an option to generate all languages and features

    [ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745461#comment-16745461 ] 

James E. King III commented on THRIFT-2790:
-------------------------------------------

I would still like to see this option - although it would only allow for the "standard" language-specific options, but I see the use cases it would solve:

1. Will my thrift file work with future languages my project(s) start using?
2. Am I using any keywords that are invalid across any language?

It sounds like given the difference between "js" and "nodejs" is a compiler flag, this won't actually generate all... so what do we want to do with it?

> thrift -gen all => an option to generate all languages and features
> -------------------------------------------------------------------
>
>                 Key: THRIFT-2790
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2790
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General), Documentation, Test Suite
>            Reporter: Roger Meier
>            Priority: Major
>         Attachments: 0001-THRIFT-2790-gen-all-option-to-easily-test-compatibil.patch, generate-all-languages.bat
>
>
> I would like to have a *thrift -gen all* option to generate everything we have in one step. This would allow proper testing of all compiler changes by using  test/ThriftTest.thrift. An optional make check target could compare different versions based on their git hash or to previous gen-all.backup folder.
> Suggested-by: Roger Meier <ro...@apache.org>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)