You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2024/05/09 18:02:15 UTC
(superset) branch table-autocomplete-catalog-fix updated (c499269aff -> f5abdabd09)
This is an automated email from the ASF dual-hosted git repository.
beto pushed a change to branch table-autocomplete-catalog-fix
in repository https://gitbox.apache.org/repos/asf/superset.git
discard c499269aff fix: table autocomplete should pass schema
new f5abdabd09 fix: table autocomplete should pass catalog
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (c499269aff)
\
N -- N -- N refs/heads/table-autocomplete-catalog-fix (f5abdabd09)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../components/AceEditorWrapper/useKeywords.test.ts | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
(superset) 01/01: fix: table autocomplete should pass catalog
Posted by be...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
beto pushed a commit to branch table-autocomplete-catalog-fix
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f5abdabd09907c2c2e5222af33e847cf8ed75c12
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Thu May 9 13:59:15 2024 -0400
fix: table autocomplete should pass catalog
---
.../components/AceEditorWrapper/useKeywords.test.ts | 15 +++++++++++++--
.../src/SqlLab/components/AceEditorWrapper/useKeywords.ts | 4 +++-
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts b/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts
index 193e715fb2..350e7ec121 100644
--- a/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts
+++ b/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts
@@ -61,6 +61,7 @@ const fakeFunctionNamesApiResult = {
};
const expectDbId = 1;
+const expectCatalog = null;
const expectSchema = 'schema1';
beforeEach(() => {
@@ -228,7 +229,12 @@ test('returns column keywords among selected tables', async () => {
),
);
storeWithSqlLab.dispatch(
- addTable({ id: expectQueryEditorId }, expectTable, expectSchema),
+ addTable(
+ { id: expectQueryEditorId },
+ expectTable,
+ expectCatalog,
+ expectSchema,
+ ),
);
});
@@ -267,7 +273,12 @@ test('returns column keywords among selected tables', async () => {
act(() => {
storeWithSqlLab.dispatch(
- addTable({ id: expectQueryEditorId }, unexpectedTable, expectSchema),
+ addTable(
+ { id: expectQueryEditorId },
+ unexpectedTable,
+ expectCatalog,
+ expectSchema,
+ ),
);
});
diff --git a/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts b/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts
index 2eac21ff39..df45290f6c 100644
--- a/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts
+++ b/superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts
@@ -146,7 +146,9 @@ export function useKeywords(
const insertMatch = useEffectEvent((editor: Editor, data: any) => {
if (data.meta === 'table') {
- dispatch(addTable({ id: queryEditorId, dbId }, data.value, schema));
+ dispatch(
+ addTable({ id: queryEditorId, dbId }, data.value, catalog, schema),
+ );
}
let { caption } = data;