[GitHub] [incubator-teaclave] mssun commented on a change in pull request #600: Add watchdog functionalities

[GitBox <gi...@apache.org>]

mssun commented on a change in pull request #600:
URL: https://github.com/apache/incubator-teaclave/pull/600#discussion_r787238555



##########
File path: services/execution/enclave/src/lib.rs
##########
@@ -77,18 +77,17 @@ fn start_service(config: &RuntimeConfig) -> Result<()> {
 
     let mut service =
         service::TeaclaveExecutionService::new(scheduler_service_endpoint, fusion_base)?;
-    let _ = service.start();
-
-    Ok(())
+    service.start()
 }
 
 #[handle_ecall]
 fn handle_start_service(input: &StartServiceInput) -> TeeServiceResult<StartServiceOutput> {
     match start_service(&input.config) {
         Ok(_) => Ok(StartServiceOutput),
+        // terminate the enclave for executor
         Err(e) => {
-            log::error!("Failed to start the service: {}", e);
-            Err(TeeServiceError::ServiceError)
+            log::error!("Service Shut Donw, Reason: {}", e);

Review comment:
       `Service shutdown, reason: {}`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org