You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eric DE MAULDE (JIRA)" <ji...@apache.org> on 2009/09/12 15:17:57 UTC
[jira] Created: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
checkoutpayment XHTML validation & default payment
--------------------------------------------------
Key: OFBIZ-2932
URL: https://issues.apache.org/jira/browse/OFBIZ-2932
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: trunk 814152
Reporter: Eric DE MAULDE
Fix For: SVN trunk
checkoutpayment.ftl doesn't validate XHTML test
More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783026#action_12783026 ]
Deepak Dixit commented on OFBIZ-2932:
-------------------------------------
Thanks Jacques for committing patch.
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932.patch, OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepak Dixit updated OFBIZ-2932:
--------------------------------
Attachment: OFBIZ-2932.patch
Here is the clean up patch:
In this patch
1) Removed the embedded styling.
2) Removed use of table.
3) Used id in form element, instead of name and made changes accordingly.
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932.patch, OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (OFBIZ-2932) checkoutpayment XHTML validation
& default payment
Posted by Deepak Dixit <de...@hotwaxmedia.com>.
Hello Eric,
This file need some more markup clean up. like
1) The "name"attribute exists in form element and the name|| attribute
of form elements is formally deprecated, and will be removed in a
subsequent version of XHTML .Use id attribute instead of name.
2) Event attribute is in lower camel case, but according to XHTML all
attribute need to be in lower case.
3) script tag is not in the correct formate.
Thanks & Regards
-----
Deepak Dixit
Eric DE MAULDE (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Eric DE MAULDE updated OFBIZ-2932:
> ----------------------------------
>
> Attachment: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
> This patch modifies
> _ checked into checked="checked"
> _ add " />" at the end of input tag
> _ add a checked default payment : it's the first, EXT_OFFLINE
>
>
>
>> checkoutpayment XHTML validation & default payment
>> --------------------------------------------------
>>
>> Key: OFBIZ-2932
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
>> Project: OFBiz
>> Issue Type: Bug
>> Components: specialpurpose/ecommerce
>> Affects Versions: SVN trunk
>> Environment: trunk 814152
>> Reporter: Eric DE MAULDE
>> Fix For: SVN trunk
>>
>> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>>
>>
>> checkoutpayment.ftl doesn't validate XHTML test
>> More, checkoutpayment hasn't a checked default payment.
>>
>
>
[jira] Updated: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2932:
----------------------------------
Attachment: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
This patch modifies
_ checked into checked="checked"
_ add " />" at the end of input tag
_ add a checked default payment : it's the first, EXT_OFFLINE
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769877#action_12769877 ]
Jacques Le Roux commented on OFBIZ-2932:
----------------------------------------
Hi Eric,
I was to apply your patch, wthout the default checked off line payment, but why did your remove this line ?
<tr><td colspan="3"><hr/></td></tr>
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2932.
----------------------------------
Resolution: Fixed
Thanks Deepak,
Your patch is in trunk at r884483.
It's a pity that the buttons to pay, see the cart, etc. are still not working under XP with FF (only IE and Opera ok). Also we have still payment and shipment infos displaying at the bottom of the right bar. I begin to wonder if we should not revert the changes, that lead to this situation, it's near a month now that those buttons are unusable...
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932.patch, OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760018#action_12760018 ]
Jacques Le Roux commented on OFBIZ-2932:
----------------------------------------
Hi Eric,
I'm not sure we want a checked default payment. A person could not acknowledge it and check also CC to pay all by card...
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772253#action_12772253 ]
Deepak Dixit commented on OFBIZ-2932:
-------------------------------------
Hello Jacques,
This file need some more cleanup to pass XHTML validation and it contain embedded styling.So please reopen this issue.
Deepak Dixit
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reopened OFBIZ-2932:
------------------------------------
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772256#action_12772256 ]
Jacques Le Roux commented on OFBIZ-2932:
----------------------------------------
Hi Deepak,
Enjoy ;)
Thanks!
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2932:
----------------------------------
Priority: Trivial (was: Major)
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2932) checkoutpayment XHTML validation &
default payment
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2932.
----------------------------------
Resolution: Fixed
Assignee: Jacques Le Roux
Thanks Eric,
Your slightly modified patch is in trunk at r831547
> checkoutpayment XHTML validation & default payment
> --------------------------------------------------
>
> Key: OFBIZ-2932
> URL: https://issues.apache.org/jira/browse/OFBIZ-2932
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: trunk 814152
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch
>
>
> checkoutpayment.ftl doesn't validate XHTML test
> More, checkoutpayment hasn't a checked default payment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.