You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by MHarish Mnsatya <sa...@gmail.com> on 2010/10/04 15:40:58 UTC

Re: [Shindig] [Issue 2085042] Optimization: Updated few checks in ConcatVisitor, to increase its coverage.

Description:
Optimization:
Updated few checks in ConcatVisitor, to increase its coverage.

In getNextSibling() function:
1) We can be ignore are text node irrespective of their content.
2) We can ignore comment nodes expect for conditional comments.

Please review this at http://codereview.appspot.com/2085042/

Affected files:
 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java
 java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java

Satya