You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/22 23:25:35 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #28484: Add execution role parameter to AddStepsOperator

Taragolis commented on code in PR #28484:
URL: https://github.com/apache/airflow/pull/28484#discussion_r1055925278


##########
tests/providers/amazon/aws/operators/test_emr_add_steps.py:
##########
@@ -224,4 +224,5 @@ def test_wait_for_completion(self, mock_add_job_flow_steps):
             job_flow_id=job_flow_id,
             steps=[],
             wait_for_completion=False,
+            execution_role_arn=None,
         )

Review Comment:
   Could we also have a test scenario in Hook?
   1. Provide value
   2. Provide empty value: `None`, `""` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org