You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/29 15:27:02 UTC

[GitHub] [spark] wangyum commented on a change in pull request #36005: [SPARK-38506][SQL] Push partial aggregation through join

wangyum commented on a change in pull request #36005:
URL: https://github.com/apache/spark/pull/36005#discussion_r837614622



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -964,6 +965,7 @@ case class Range(
 case class Aggregate(
     groupingExpressions: Seq[Expression],
     aggregateExpressions: Seq[NamedExpression],
+    isPartialOnly: Boolean,

Review comment:
       Adding a new LogicalPlan is not easy to maintain because lots of rules need to consider that rule. For example:
   
   https://github.com/apache/spark/blob/eb30a27e53158e64fffaa6d32ff9369ffbae0384/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3814-L3816




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org