You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sadanand48 (via GitHub)" <gi...@apache.org> on 2023/08/29 05:59:25 UTC
[GitHub] [ozone] sadanand48 opened a new pull request, #5230: HDDS-3420. Enable TestSCMSafeModeWithPipelineRules test cases
sadanand48 opened a new pull request, #5230:
URL: https://github.com/apache/ozone/pull/5230
## What changes were proposed in this pull request?
The changes that fix the test :
1. Setting `OZONE_DATANODE_PIPELINE_LIMIT` to 1 , earlier set to 50 . With Multi-Raft enabled by default, each DN was participating in multiple pipelines which caused failures in some assertions that asserted pipeline count. This test was written prior to multi raft.
2. Outdated waiting logic : When pipeline scrubber creates pipelines , SCM persists its info in its RocksDB. After a cluster/SCM restart, SCM loads back the persisted pipelines in its memory . pipelineManager.getPipelines() returns this info.
This is independent of how many dataNodes are up or down as it is purely loading it from SCM DB. Removed such redundant checks.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3420
## How was this patch tested?
Unit test fix
Ran the test for 100 iterations : https://github.com/sadanand48/hadoop-ozone/actions/runs/6003180099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #5230: HDDS-3420. Enable TestSCMSafeModeWithPipelineRules test cases
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5230:
URL: https://github.com/apache/ozone/pull/5230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #5230: HDDS-3420. Enable TestSCMSafeModeWithPipelineRules test cases
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5230:
URL: https://github.com/apache/ozone/pull/5230#issuecomment-1712722904
Thanks @sadanand48 for the patch, @aryangupta1998 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org