[GitHub] [helix] i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.
URL: https://github.com/apache/helix/pull/363#discussion_r308443459
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java
 ##########
 @@ -597,7 +611,7 @@ public ClusterConstraints getConstraint(ClusterConstraints.ConstraintType type)
    * Notify the cache that some part of the cluster data has been changed.
    */
   public void notifyDataChange(HelixConstants.ChangeType changeType) {
 
 Review comment:
   Thanks for using AtomicBoolean, the purpose is much clearer now. But can you add more comment on why we need a lock-free condition at this case, for better reference purpose in the future

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services