[GitHub] [ozone] adoroszlai commented on pull request #2053: HDDS-4988. Cancel duplicate PR workflows

[GitBox <gi...@apache.org>]

adoroszlai commented on pull request #2053:
URL: https://github.com/apache/ozone/pull/2053#issuecomment-802732765


   Thanks @elek for the review.
   
   > One thing what I am not sure about it: using git modules.
   > 
   > By default, I agree, that using standard features is a good thing. But earlier, when I used git submodules I had some problems with the usability (warnings, additional commands, conflict resolutions). With this approach everybody will see the git subodules after an Ozone checkout even if this feature is required only for one specific github action.
   
   I have no prior experience using submodules, but now read a bit about it and tried some commands.
   
   I think warnings and additional commands apply only if I need to interact with the submodule (eg. if it's required for compilation).  Since this one is intended for CI only, most developers do not need that.  In this case `.github/actions/cancel-workflow-runs` will be just an empty dir when on a branch that already has this commit, and removed when checking out another, older branch.
   
   Only if I run `git submodule init` and `git submodule update`, and then switch to another branch, will I run into warnings and untracked files:
   
   ```
   warning: unable to rmdir '.github/actions/cancel-workflow-runs': Directory not empty
   ```
   
   ```
   Untracked files:
     (use "git add <file>..." to include in what will be committed)
   	.github/actions/
   ```
   
   In this case I need to remember to `git submodule deinit --all` before the switch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org