You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/30 06:16:16 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7031: fix test_acl_sharenetworks from components

DaanHoogland commented on code in PR #7031:
URL: https://github.com/apache/cloudstack/pull/7031#discussion_r1059256319


##########
tools/marvin/marvin/cloudstackTestCase.py:
##########
@@ -99,7 +99,9 @@ def cleanup_resources(cls, api_client, resources):
             Delete resources (created during tests)
         """
         for obj in resources:
-            if isinstance(obj, VirtualMachine):
+            if isinstance(obj, Domain):
+                obj.delete(api_client, cleanup=true)

Review Comment:
   ```suggestion
                   obj.delete(api_client, cleanup=True)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org