[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2697: [Feature][Connector-V2] Add influxDB connector source

[GitBox <gi...@apache.org>]

TyrantLucifer commented on PR #2697:
URL: https://github.com/apache/incubator-seatunnel/pull/2697#issuecomment-1250482987

   > > > > can you add e2e-testcase(spark)?
   > > > 
   > > > 
   > > > there is a conflict of the okhttp jar between the Spark jar and the influxdb connector. At present, this problem is solved by specifying the replacement of conflicting packages in the spark jars directory in the document
   > > 
   > > 
   > > @CalvinKirs PTAL
   > 
   > We'd better be able to rename these jars @TyrantLucifer WDYT?
   
   Yes, aggre with you, you can add `maven-shade` plugin in your pom to rename these jars. BTW, could you please use `httpclient`, not use `okhttp`, it's better to unify versions and dependencies for http dependencies. In subsequent iterations, we need to abstract this http-related functionality into public modules and replace them uniformly with the renamed httpclient. What do you think about? @531651225 @CalvinKirs 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org