[jira] Commented: (THRIFT-129) Update CSharp compiler and Library to generate data structures that extend TBase.cs

["Craig Kimerer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627835#action_12627835 ] 

Craig Kimerer commented on THRIFT-129:
--------------------------------------

Just by glancing at this diff, looks like this wont compile if you have any exceptions defined in your .thrift files.

> Update CSharp compiler and Library to generate data structures that extend TBase.cs
> -----------------------------------------------------------------------------------
>
>                 Key: THRIFT-129
>                 URL: https://issues.apache.org/jira/browse/THRIFT-129
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (C#), Library (C#)
>            Reporter: Michael Ward
>         Attachments: my.patch
>
>
> The C# library does not currently have a base class/interface for the data structures being generated to extend from.  Without this you are required to access the Read(TProtocol) and Write(TProtocol) methods via reflection.  
> I have created a patch the defines the TBase class and updates the generator to use this for the data structures created.  This change is similar to what Thrift currently provides for Java.
> Cheers,
> Mike

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.