You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by tf...@apache.org on 2017/05/23 00:03:24 UTC

[02/27] lucene-solr:jira/solr-10233: SOLR-10413: Fix test failure (with better json validators we can capture invalid input)

SOLR-10413: Fix test failure (with better json validators we can capture invalid input)


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/9e3c710d
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/9e3c710d
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/9e3c710d

Branch: refs/heads/jira/solr-10233
Commit: 9e3c710d0c7d8d82468c4e6a99717b08655db486
Parents: d30d012
Author: Cao Manh Dat <da...@apache.org>
Authored: Fri May 19 09:35:43 2017 +0700
Committer: Cao Manh Dat <da...@apache.org>
Committed: Fri May 19 09:35:43 2017 +0700

----------------------------------------------------------------------
 .../test/org/apache/solr/handler/admin/TestCollectionAPIs.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/9e3c710d/solr/core/src/test/org/apache/solr/handler/admin/TestCollectionAPIs.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/handler/admin/TestCollectionAPIs.java b/solr/core/src/test/org/apache/solr/handler/admin/TestCollectionAPIs.java
index dec1e04..7b79443 100644
--- a/solr/core/src/test/org/apache/solr/handler/admin/TestCollectionAPIs.java
+++ b/solr/core/src/test/org/apache/solr/handler/admin/TestCollectionAPIs.java
@@ -27,6 +27,7 @@ import java.util.List;
 import java.util.Map;
 
 import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.api.ApiException;
 import org.apache.solr.client.solrj.SolrRequest;
 import org.apache.solr.common.cloud.ZkNodeProps;
 import org.apache.solr.common.params.CollectionParams;
@@ -118,7 +119,7 @@ public class TestCollectionAPIs extends SolrTestCaseJ4 {
     );
 
     compareOutput(apiBag, "/collections/collName", POST,
-        "{modify : {rule : 'replica:*,cores:<5', autoAddReplicas : false} }", null,
+        "{modify : {rule : ['replica:*, cores:<5'], autoAddReplicas : false} }", null,
         "{collection: collName, operation : modifycollection , autoAddReplicas : 'false', rule : [{replica: '*', cores : '<5' }]}"
     );
     compareOutput(apiBag, "/cluster", POST,
@@ -185,7 +186,7 @@ public class TestCollectionAPIs extends SolrTestCaseJ4 {
     };
     try {
       api.call(req, rsp);
-    } catch (ApiBag.ExceptionWithErrObject e) {
+    } catch (ApiException e) {
       throw new RuntimeException(e.getMessage() + Utils.toJSONString(e.getErrs()), e);
 
     }